Add option to skip 32-bit go test
#412
Conversation
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
This should probably target the next branch, not master.
|
@marten-seemann based on a quick search, I can't find documentation on weather environment variables with boolean-looking value are interpreted as Considering the approach in this PR is consistent with the way by which other boolean config is parsed elsewhere (e.g. |
|
I'm not really concerned about consistency here. @galargh might be though ;) |
That's correct. If it's in
Yes, please! Testing it out on a real repo would be extremely helpful.
Let's make this change too. We don't want to release it immediately to all the repos. If you want it to reach your repo earlier than the next major release, you can use technical preview feature - https://github.com/protocol/.github#technical-preview |
masih
force-pushed
the
masih/go_test_skip32bit
branch
from
273a162 to
6a78a03
Compare
Test out a configuration to skip 32-bit go test via JSON configuration. Relates to protocol/.github#412
masih
force-pushed
the
masih/go_test_skip32bit
branch
from
6a78a03 to
7f0e882
Compare
Test out a configuration to skip 32-bit go test via JSON configuration. Relates to protocol/.github#412
masih
force-pushed
the
masih/go_test_skip32bit
branch
from
7f0e882 to
5ab0e8c
Compare
Introduce an option to configure `go-test` to allow completely skipping `32-bit` tests. Fixes #388
masih
force-pushed
the
masih/go_test_skip32bit
branch
from
5ab0e8c to
ccdf0fc
Compare
|
@galargh @marten-seemann the changes are tested here. please let me know if there is anything else in this PR you'd like changed. Many thanks both for the speedy review 🚀 |
Test out a configuration to skip 32-bit go test via JSON configuration. Relates to protocol/.github#412
Test out a configuration to skip 32-bit go test via JSON configuration. Relates to protocol/.github#412
galargh
left a comment
galargh
left a comment
There was a problem hiding this comment.
Thank you 🙇 Let me know if you need help setting up Tech Preview for any of the repos.
* Add option to skip `32-bit` go test (#412) Introduce an option to configure `go-test` to allow completely skipping `32-bit` tests. Fixes #388 * Run at most 1 dispatch job per ref (#414) * fix: check if git tag returns any results (#415) * make go generate print the commands it executs (#440) * use pull_request_target event for release-check workflow (#295) * Revert "include cross-package coverage in codecov" * Revert "Revert "include cross-package coverage in codecov"" * Make automerge a reusable workflow (#260) * move automerge from template to workflows * make automerge reusable and use it from new automerge template * pass parent job name to reusable automerge * check github actions yamls (#272) * check github actions yamls * make yaml linter happy about go-test * mention VS Code YAML extension in the readme * add info about other YAML checking extensions * make yaml checker more generic * use validate-yaml-schema action from mainline (#277) * upgrade lewagon/wait-on-check-action to v1.1.1 (#278) * always add a version.json file if it doesn't exist (#281) * fix go-test runner string * check if tag already exists in release-check (#287) * allow specifying custom PATH for 386 arch (#289) * use pull_request_target event for release-check workflow * add comment on missing version.json * chore: revert release checker path trigger change * chore: add footnote when non-docs files are modified with the release * fix: prev version calculation * feat: allow configuring custom go-test runners (#443) * feat: allow configuring custom go-test runners * docs: update readme to include info on configuration variables * feat: allow skipping go-test on certain OSes (#455) * feat: standarise JSON config reading * feat: allow skipping go-test on certain OSes * fix: go-test conditional * chore: show config after extracting it * chore: udpate actions and go modules (#458) * fix: source read-config from next for now * simplify Go version upgrade procedure (#280) * chore: simplify Go version upgrade procedure * chore: add default for the go-version input of release-check * Update .github/actions/copy-workflow-go/action.yml * Update configs/README.md Co-authored-by: Laurent Senta <[email protected]> --------- Co-authored-by: Laurent Senta <[email protected]> * Go through all the workflows and clean them up ahead of the next major release (#462) * chore: clean up deprecated set-output * chore: do not use substitution inside run * chore: do not use substitution in if * chore: skip env var brakets where possible * fix: env var substitution * fix: double toJSON * Update templates/.github/workflows/js-test-and-release.yml * feat: create gh releases in release-check/releaser workflows (#456) * feat: create gh releases in release-check/releaser workflows * fix: fill expr in release check workflow * fix: add missing gh token in release check * fix: add missing prev version env var in release check workflow * fix: release check in release check * chore: clean up obsolete step from releaser * fix: step outputs in release workflows * fix: labels in releaser * fix: action gh release * update go version to 1.20.x (#463) * update go version to 1.20.x * fix: go 1.20 upgrade * Revert "fix: go 1.20 upgrade" This reverts commit ceb72ef. * clean up where source ref was set to next (#464) * perform self-review before final release --------- Co-authored-by: Masih H. Derkani <[email protected]> Co-authored-by: Marten Seemann <[email protected]> Co-authored-by: Laurent Senta <[email protected]>
Introduce an option to configure
go-testto allow completely skipping32-bittests.Fixes #388